-
Notifications
You must be signed in to change notification settings - Fork 204
🐛 Respect log level from the command-line arguments #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Respect log level from the command-line arguments #685
Conversation
|
Welcome @makhov! |
|
Hi @makhov. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/test pull-apiserver-network-proxy-test-master |
|
/retest |
|
/test pull-apiserver-network-proxy-test-master |
4 similar comments
|
/test pull-apiserver-network-proxy-test-master |
|
/test pull-apiserver-network-proxy-test-master |
|
/test pull-apiserver-network-proxy-test-master |
|
/test pull-apiserver-network-proxy-test-master |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako, makhov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Great to see it merged, thank you! Do you have any plans for a new release with the fix? |
…from-args 🐛 Respect log level from the command-line arguments (cherry picked from commit 014374a)
|
This PR introduced a condition ( to test:
to test that this PR introduced an error
|
…g-level-from-args" This reverts commit 4ce5f06. This commit reverts a previous modification to the flag handling logic in the agent and server's main() functions. A prior change introduced a condition (`if local.Lookup("v") == nil`) before setting the default klog verbosity level. This condition was incorrect because `klog.InitFlags()` always defines the `-v` flag, meaning the default verbosity was never being applied. This caused the effective log level to fall back to klog's default of `0` instead of the intended `4`. This change restores the original, correct behavior by unconditionally setting the verbosity to `4`. This ensures logs are visible by default while still allowing the user to override the setting via the command line.
…g-level-from-args" This reverts commit 4ce5f06. This commit reverts a previous modification to the flag handling logic in the agent and server's main() functions. A prior change introduced a condition (`if local.Lookup("v") == nil`) before setting the default klog verbosity level. This condition was incorrect because `klog.InitFlags()` always defines the `-v` flag, meaning the default verbosity was never being applied. This caused the effective log level to fall back to klog's default of `0` instead of the intended `4`. This change restores the original, correct behavior by unconditionally setting the verbosity to `4`. This ensures logs are visible by default while still allowing the user to override the setting via the command line.
…g-level-from-args" This reverts commit 4ce5f06. This commit reverts a previous modification to the flag handling logic in the agent and server's main() functions. A prior change introduced a condition (`if local.Lookup("v") == nil`) before setting the default klog verbosity level. This condition was incorrect because `klog.InitFlags()` always defines the `-v` flag, meaning the default verbosity was never being applied. This caused the effective log level to fall back to klog's default of `0` instead of the intended `4`. This change restores the original, correct behavior by unconditionally setting the verbosity to `4`. This ensures logs are visible by default while still allowing the user to override the setting via the command line.
…g-level-from-args" This reverts commit 4ce5f06. This commit reverts a previous modification to the flag handling logic in the agent and server's main() functions. A prior change introduced a condition (`if local.Lookup("v") == nil`) before setting the default klog verbosity level. This condition was incorrect because `klog.InitFlags()` always defines the `-v` flag, meaning the default verbosity was never being applied. This caused the effective log level to fall back to klog's default of `0` instead of the intended `4`. This change restores the original, correct behavior by unconditionally setting the verbosity to `4`. This ensures logs are visible by default while still allowing the user to override the setting via the command line.
Revert "Merge pull request #685 from makhov/respect-log-level-from-args"
Backport to release-0.31 Revert "Merge pull request #685 from makhov/respect-log-level-from-args"
Backport to release-0.33 Revert "Merge pull request #685 from makhov/respect-log-level-from-args"
Backport to release-0.32 Revert "Merge pull request #685 from makhov/respect-log-level-from-args"
Currently, the log level is hardcoded and konnectivity is usually quite noisy